Move PublicKey to a separate crate #911
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Miroslav Kovar <miroslav.kovar@absa.africa>
Codecov Report
@@ Coverage Diff @@
## main #911 +/- ##
==========================================
- Coverage 43.37% 43.31% -0.07%
==========================================
Files 438 439 +1
Lines 34777 34823 +46
Branches 7580 7589 +9
==========================================
- Hits 15084 15082 -2
- Misses 15231 15280 +49
+ Partials 4462 4461 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Patrik-Stas
approved these changes
Aug 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows using
PublicKeyin the forthcomingdid_keycrate without importing the entiredid_peercrate unnecessarily. The only reasonPublicKeyresided in thedid_peerin the first place was because it was not used anywhere else yet.